linux-kernel - Re: [PATCH 2.6.31-rc2] Missing volume controls for Intel HDA (ALC269/EeePC)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h8wizqlw7.wl%tiwai@suse.de>
Date:	Wed, 08 Jul 2009 16:39:36 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Darren Salt <linux@...mustbejoking.demon.co.uk>
Cc:	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2.6.31-rc2] Missing volume controls for Intel HDA (ALC269/EeePC)

At Wed, 08 Jul 2009 15:29:49 +0100,
Darren Salt wrote:
> 
> There is a regression, introduced in aa202455eec51699e44f658530728162cefa1307
> (in alsa-kernel) which I noticed when trying to use the headphone socket on
> my EeeCPC 901: the output was *very* quiet, practically silent.
> 
> This patch corrects the control types to that which was obviously intended in
> the referenced commit.
> 
> Signed-Off-By: Darren Salt <linux@...mustbejoking.demon.co.uk>

Bah, looks like a wrong version was merged to the tree.
Applied now.  Thanks for a quick fix!


Takashi

> --- a/sound/pci/hda/patch_realtek.c	2009-07-05 17:30:41.000000000 +0100
> +++ b/sound/pci/hda/patch_realtek.c	2009-07-08 14:50:38.000000000 +0100
> @@ -12878,9 +12878,9 @@
>  
>  static struct snd_kcontrol_new alc269_eeepc_mixer[] = {
>  	HDA_CODEC_MUTE("Speaker Playback Switch", 0x14, 0x0, HDA_OUTPUT),
> -	HDA_CODEC_MUTE("Speaker Playback Volume", 0x02, 0x0, HDA_OUTPUT),
> +	HDA_CODEC_VOLUME("Speaker Playback Volume", 0x02, 0x0, HDA_OUTPUT),
>  	HDA_CODEC_MUTE("Headphone Playback Switch", 0x15, 0x0, HDA_OUTPUT),
> -	HDA_CODEC_MUTE("Headphone Playback Volume", 0x03, 0x0, HDA_OUTPUT),
> +	HDA_CODEC_VOLUME("Headphone Playback Volume", 0x03, 0x0, HDA_OUTPUT),
>  	{ } /* end */
>  };
>  
> 
> -- 
> | Darren Salt            | linux at youmustbejoking | nr. Ashington, | Doon
> | using Debian GNU/Linux | or ds    ,demon,co,uk    | Northumberland | Army
> |   <URL:http://www.youmustbejoking.demon.co.uk/progs.packages.html>
> 
> I have one illusion, and that's that I have no illusions.
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/