linux-kernel - Re: [BUG] Linux-2.6.31-rc1-git9 Cannot Recognize Empty DVD Media

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8db1092f0907081122l7152e8bcyf2fd73d1386f6ac6@mail.gmail.com>
Date:	Wed, 8 Jul 2009 20:22:51 +0200
From:	Maciej Rutecki <maciej.rutecki@...il.com>
To:	James Bottomley <James.Bottomley@...senpartnership.com>
Cc:	Daniel Walker <dwalker@...o99.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Tarkan Erimer <tarkan.erimer@...knet.net.tr>,
	Jens Axboe <jens.axboe@...cle.com>,
	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org
Subject: Re: [BUG] Linux-2.6.31-rc1-git9 Cannot Recognize Empty DVD Media

2009/7/8 James Bottomley <James.Bottomley@...senpartnership.com>:
> On Wed, 2009-07-08 at 09:06 -0700, Daniel Walker wrote:
>> On Wed, 2009-07-08 at 09:27 -0500, James Bottomley wrote:
>> >
>> > You might also try this patch from martin petersen:  it will print out
>> > the actual command that's causing the problems ... that might give a
>> > clue.
>> >
>> > James
>>
>> On the bugzilla entry ,
>>
>> http://bugzilla.kernel.org/show_bug.cgi?id=13727
>>
>> Thomas Meyer indicated it was (possibly) the following commit,
>>
>> 018e0446890661504783f92388ecce7138c1566d
>>
>> I added Jens to the CC ..
>
> So thats:
>
> commit 018e0446890661504783f92388ecce7138c1566d
> Author: Jens Axboe <jens.axboe@...cle.com>
> Date:   Fri Jun 26 16:27:10 2009 +0200
>
>    block: get rid of queue-private command filter
>
> What this tends to suggest is that the command filter was blocking some
> type of command sent from user space which is causing the problem, and
> now we're letting it through.  Restoring the command filter will work
> around the problem, but the root cause should be finding and fixing
> whatever is issuing the commands in the first place.
>
> James
>
>
>

Confirm. I find some time, and do bisection:
018e0446890661504783f92388ecce7138c1566d is first bad commit
commit 018e0446890661504783f92388ecce7138c1566d
Author: Jens Axboe <jens.axboe@...cle.com>
Date:   Fri Jun 26 16:27:10 2009 +0200

    block: get rid of queue-private command filter

    The initial patches to support this through sysfs export were broken
    and have been if 0'ed out in any release. So lets just kill the code
    and reclaim some space in struct request_queue, if anyone would later
    like to fixup the sysfs bits, the git history can easily restore
    the removed bits.

    Signed-off-by: Jens Axboe <jens.axboe@...cle.com>

:040000 040000 aaaec08cd15fe376286ef07b90eddb60f7dc98a1
5cc15daa4a596dcb97300baf7828e78ceeb40d5e M      block
:040000 040000 f1fbb94e7136c18e0df7d967800073a98901d51d
0d0a6e6e360b75daf9dc673a5ef0b7d745d5718e M      drivers
:040000 040000 e56a6498a1ca54adce4972cc2fe092a6e054165f
1c1e974e56532151cf0c98bfeb1ff05971e5b2c1 M      include

I revert this commit and in -rc2 k3b can see dvd drive. (some
explanation: I have little different problem; k3b can't see/detect DVD
drive).



Regards
-- 
Maciej Rutecki
http://www.maciek.unixy.pl
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/