| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20090708200741.GI5301@lenovo> Date: Thu, 9 Jul 2009 00:07:41 +0400 From: Cyrill Gorcunov <gorcunov@...nvz.org> To: Ingo Molnar <mingo@...e.hu>, "H. Peter Anvin" <hpa@...or.com> Cc: Thomas Gleixner <tglx@...utronix.de>, "Maciej W. Rozycki" <macro@...ux-mips.org>, Vegard Nossum <vegard.nossum@...il.com>, LKML <linux-kernel@...r.kernel.org> Subject: [PATCH -tip] x86,apic -- don't forget to disconnect BSP discrete apic In case of discrete APIC cpu_has_apic could be not set. This leads to disconnect_bsp_APIC is not called where it should. Tested-by: Vegard Nossum <vegard.nossum@...il.com> Signed-off-by: Cyrill Gorcunov <gorcunov@...nvz.org> --- Please review. arch/x86/kernel/apic/io_apic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.git/arch/x86/kernel/apic/io_apic.c ===================================================================== --- linux-2.6.git.orig/arch/x86/kernel/apic/io_apic.c +++ linux-2.6.git/arch/x86/kernel/apic/io_apic.c @@ -2002,7 +2002,7 @@ void disable_IO_APIC(void) /* * Use virtual wire A mode when interrupt remapping is enabled. */ - if (cpu_has_apic) + if (cpu_has_apic || smp_found_config) disconnect_bsp_APIC(!intr_remapping_enabled && ioapic_i8259.pin != -1); } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists