linux-kernel - [PATCH] arch/blackfin/kernel/traps.c: Add visually separating newlines to printks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1247090122.25028.21.camel@Joe-Laptop.home>
Date:	Wed, 08 Jul 2009 14:55:22 -0700
From:	Joe Perches <joe@...ches.com>
To:	Mike Frysinger <vapier.adi@...il.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Yinghai Lu <yinghai@...nel.org>, Ingo Molnar <mingo@...e.hu>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: [PATCH] arch/blackfin/kernel/traps.c: Add visually separating
 newlines to printks

On Mon, 2009-07-06 at 16:36 -0400, Mike Frysinger wrote:
> On Mon, Jul 6, 2009 at 16:33, Linus Torvalds wrote:
> > On Mon, 6 Jul 2009, Mike Frysinger wrote:
> >> >  #ifdef CONFIG_DEBUG_VERBOSE
> >> > -       printk(KERN_EMERG "\n" KERN_EMERG "Double Fault\n");
> >> > +       printk(KERN_EMERG "Double Fault\n");
> >> dropped a newline.  we've largely made sure the newlines and such were
> >> as we want in the output ... in this case, it is not a matter of
> >> adding a newline where one did not exist before
> > Note that the 'printk' itself will add a required newline these days.
> > If you do want the empty line, it should look like
> >        printk(KERN_EMERG "\nDouble Fault\n");
> yes, the newlines here were explicit, not follow up to previous ones
> missing lines.  i ignored the ones Joe (correctly) dropped due to
> appending rather than explicit spacing.

Commit ad361c9884e809340f6daca80d56a9e9c871690a dropped some
arguably useful newlines from printks unnecessarily.

Signed-off-by: Joe Perches <joe@...ches.com>

diff --git a/arch/blackfin/kernel/traps.c b/arch/blackfin/kernel/traps.c
index 8a1caf2..598d42f 100644
--- a/arch/blackfin/kernel/traps.c
+++ b/arch/blackfin/kernel/traps.c
@@ -212,7 +212,7 @@ asmlinkage void double_fault_c(struct pt_regs *fp)
 	console_verbose();
 	oops_in_progress = 1;
 #ifdef CONFIG_DEBUG_VERBOSE
-	printk(KERN_EMERG "Double Fault\n");
+	printk(KERN_EMERG "\nDouble Fault\n");
 #ifdef CONFIG_DEBUG_DOUBLEFAULT_PRINT
 	if (((long)fp->seqstat &  SEQSTAT_EXCAUSE) == VEC_UNCOV) {
 		unsigned int cpu = smp_processor_id();
@@ -590,7 +590,7 @@ asmlinkage void trap_c(struct pt_regs *fp)
 
 		if (oops_in_progress) {
 			/* Dump the current kernel stack */
-			verbose_printk(KERN_NOTICE "Kernel Stack\n");
+			verbose_printk(KERN_NOTICE "\nKernel Stack\n");
 			show_stack(current, NULL);
 			print_modules();
 #ifndef CONFIG_ACCESS_CHECK
@@ -1009,7 +1009,7 @@ void dump_bfin_process(struct pt_regs *fp)
 			verbose_printk(KERN_NOTICE "invalid mm\n");
 	} else
 		verbose_printk(KERN_NOTICE
-			       "No Valid process in current context\n");
+			       "\nNo Valid process in current context\n");
 #endif
 }
 
@@ -1184,7 +1184,7 @@ unlock:
 		verbose_printk(KERN_NOTICE "ICPLB_FAULT_ADDR: %s\n", buf);
 	}
 
-	verbose_printk(KERN_NOTICE "PROCESSOR STATE:\n");
+	verbose_printk(KERN_NOTICE "\nPROCESSOR STATE:\n");
 	verbose_printk(KERN_NOTICE " R0 : %08lx    R1 : %08lx    R2 : %08lx    R3 : %08lx\n",
 		fp->r0, fp->r1, fp->r2, fp->r3);
 	verbose_printk(KERN_NOTICE " R4 : %08lx    R5 : %08lx    R6 : %08lx    R7 : %08lx\n",


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/