linux-kernel - Re: [PATCH] elfcore.h : Fix UML build breakage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090708043036.GA5917@cr0.nay.redhat.com>
Date:	Wed, 8 Jul 2009 12:30:36 +0800
From:	Amerigo Wang <xiyou.wangcong@...il.com>
To:	Parag Warudkar <parag.lkml@...il.com>
Cc:	linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
	akpm@...ux-foundation.org, teawater@...il.com, mingo@...e.hu,
	tj@...nel.org, xiyou.wangcong@...il.com
Subject: Re: [PATCH] elfcore.h : Fix UML build breakage

On Tue, Jul 07, 2009 at 10:41:50PM -0400, Parag Warudkar wrote:
>Commit a65e7bfcd74e4c0939f235d2bf9f48ddb3a57991 breaks UML build with 
>below error - 
>
>In file included from fs/proc/kcore.c:17:
>include/linux/elfcore.h: In function ‘elf_core_copy_task_regs’:
>include/linux/elfcore.h:129: error: implicit declaration of function 
>‘task_pt_regs’
>
>Fix this by restoring the previous behavior of returning 0 for all arches 
>like UML that don't define task_pt_regs.

Good catch!

>
>Signed-off-by: Parag Warudkar <parag.lkml@...il.com>
>
>diff --git a/include/linux/elfcore.h b/include/linux/elfcore.h
>index 03ec167..28f722e 100644
>--- a/include/linux/elfcore.h
>+++ b/include/linux/elfcore.h
>@@ -125,7 +125,7 @@ static inline int elf_core_copy_task_regs(struct task_struct *t, elf_gregset_t*
> #ifdef ELF_CORE_COPY_TASK_REGS
> 	
> 	return ELF_CORE_COPY_TASK_REGS(t, elfregs);
>-#else
>+#elif defined task_pt_regs
> 	elf_core_copy_regs(elfregs, task_pt_regs(t));
> #endif
> 	return 0;

#elif defined doesn't match #ifdef well, how about:

#if defined (ELF_CORE_COPY_TASK_REGS)
...
#elif defined (task_pt_regs)
...
#endif

?

Thank you.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/