linux-kernel - Re: [PATCH] sound: pci/hda/patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hprcb4su9.wl%tiwai@suse.de>
Date:	Wed, 08 Jul 2009 08:00:30 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Jaswinder Singh Rajput <jaswinder@...nel.org>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sound: pci/hda/patch_via.c fix compilation warning

At Wed, 08 Jul 2009 11:27:50 +0530,
Jaswinder Singh Rajput wrote:
> 
> On Wed, 2009-07-08 at 14:18 +1000, Stephen Rothwell wrote:
> > Hi Takashi,
> > 
> > Today's linux-next build (x86_64 allmodconfig) produced these warnings:
> > 
> > sound/pci/hda/patch_via.c: In function 'via_mux_enum_put':
> > sound/pci/hda/patch_via.c:395: warning: unused variable 'vendor_id'
> > sound/pci/hda/patch_via.c: In function 'get_mux_nids':
> > sound/pci/hda/patch_via.c:1337: warning: unused variable 'type'
> > sound/pci/hda/patch_via.c:1354: warning: no return statement in function returning non-void
> > 
> > Introduced by commit 337b9d02b4873ceac91565272545fb6fd446d939 ("ALSA: hda
> > - Fix capture source selection in patch_via.c").
> > 
> 
> [PATCH] sound: pci/hda/patch_via.c fix compilation warning
> 
> sound/pci/hda/patch_via.c: In function 'via_mux_enum_put':
> sound/pci/hda/patch_via.c:395: warning: unused variable 'vendor_id'
> sound/pci/hda/patch_via.c: In function 'get_mux_nids':
> sound/pci/hda/patch_via.c:1337: warning: unused variable 'type'
> sound/pci/hda/patch_via.c:1354: warning: no return statement in function returning non-void
> 
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...il.com>

It was already fixed a few minutes ago :)  Thanks anyway.


Takashi


> ---
>  sound/pci/hda/patch_via.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/pci/hda/patch_via.c b/sound/pci/hda/patch_via.c
> index 38db459..d05b718 100644
> --- a/sound/pci/hda/patch_via.c
> +++ b/sound/pci/hda/patch_via.c
> @@ -392,7 +392,6 @@ static int via_mux_enum_put(struct snd_kcontrol *kcontrol,
>  	struct hda_codec *codec = snd_kcontrol_chip(kcontrol);
>  	struct via_spec *spec = codec->spec;
>  	unsigned int adc_idx = snd_ctl_get_ioffidx(kcontrol, &ucontrol->id);
> -	unsigned int vendor_id = codec->vendor_id;
>  
>  	if (!spec->mux_nids[adc_idx])
>  		return -EINVAL;
> @@ -1330,11 +1329,10 @@ static int via_auto_init(struct hda_codec *codec)
>  	return 0;
>  }
>  
> -static int get_mux_nids(struct hda_codec *codec)
> +static void get_mux_nids(struct hda_codec *codec)
>  {
>  	struct via_spec *spec = codec->spec;
>  	hda_nid_t nid, conn[8];
> -	unsigned int type;
>  	int i, n;
>  
>  	for (i = 0; i < spec->num_adc_nids; i++) {
> -- 
> 1.6.0.6
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/