linux-kernel - Re: [BUG] Linux-2.6.31-rc1-git9 Cannot Recognize Empty DVD Media

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090709075004.GH23611@kernel.dk>
Date:	Thu, 9 Jul 2009 09:50:04 +0200
From:	Jens Axboe <jens.axboe@...cle.com>
To:	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
Cc:	James.Bottomley@...senPartnership.com, dwalker@...o99.com,
	maciej.rutecki@...il.com, akpm@...ux-foundation.org,
	tarkan.erimer@...knet.net.tr, linux-kernel@...r.kernel.org,
	linux-scsi@...r.kernel.org
Subject: Re: [BUG] Linux-2.6.31-rc1-git9 Cannot Recognize Empty DVD Media

On Thu, Jul 09 2009, FUJITA Tomonori wrote:
> From: FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
> Subject: [PATCH] block: call blk_scsi_ioctl_init()
> 
> Currently, blk_scsi_ioctl_init() is not called so
> blk_default_cmd_filter isn't initalized. Some commands are not blocked
> wrongly.
> 
> This fixes a regression introduced:
> 
> commit 018e0446890661504783f92388ecce7138c1566d
> Author: Jens Axboe <jens.axboe@...cle.com>
> Date:   Fri Jun 26 16:27:10 2009 +0200
> 
>     block: get rid of queue-private command filter
> 
> Signed-off-by: FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
> ---
>  block/scsi_ioctl.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/block/scsi_ioctl.c b/block/scsi_ioctl.c
> index f0e0ce0..e5b1001 100644
> --- a/block/scsi_ioctl.c
> +++ b/block/scsi_ioctl.c
> @@ -680,3 +680,4 @@ int __init blk_scsi_ioctl_init(void)
>  	blk_set_cmd_filter_defaults(&blk_default_cmd_filter);
>  	return 0;
>  }
> +fs_initcall(blk_scsi_ioctl_init);
> -- 
> 1.6.0.6

You beat me to it, it was the missing call as I suspected. This
works, I verified it myself. Applied to for-linus, going upstream
soon.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/