linux-kernel - Re: [PATCH]: Rename REQ_COPY_USER to more descriptive REQ_HAS_TAIL_SPACE_FOR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 09 Jul 2009 22:30:20 +0400
From:	Vladislav Bolkhovitin <vst@...b.net>
To:	Jens Axboe <jens.axboe@...cle.com>
CC:	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	scst-devel@...ts.sourceforge.net, Tejun Heo <tj@...nel.org>,
	Boaz Harrosh <bharrosh@...asas.com>,
	James Bottomley <James.Bottomley@...senPartnership.com>,
	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>
Subject: Re: [PATCH]: Rename REQ_COPY_USER to more descriptive	REQ_HAS_TAIL_SPACE_FOR_PADDING

Jens Axboe, on 07/09/2009 10:17 PM wrote:
> On Thu, Jul 09 2009, Vladislav Bolkhovitin wrote:
>> Currently names of REQ_COPY_USER and __REQ_COPY_USER constants are confusing,
>> because they actually mean that the buffer for the corresponding requests
>> has space in the tail for padding in case of DMA padding restrictions.
> 
> No, that's not what it means, the fact that there's padding room is a
> side effect of the map type. So I'd suggest adding a comment above that
> if {} in blk_rq_map_sg(), something that should have been there from the
> beginning.

Can you elaborate a bit more about what REQ_COPY_USER should mean, please?

As far as I can see from the sources, currently it's used to only to 
determine if there is the padding space. Maybe, the original meaning 
doesn't make sense anymore?

Thanks,
Vlad



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/