linux-kernel - Re: [PATCH -tip] x86,apic -- don't forget to disconnect BSP discrete apic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4A5567E9.5080403@zytor.com>
Date:	Wed, 08 Jul 2009 20:45:45 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Cyrill Gorcunov <gorcunov@...nvz.org>
CC:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	"Maciej W. Rozycki" <macro@...ux-mips.org>,
	Vegard Nossum <vegard.nossum@...il.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -tip] x86,apic -- don't forget to disconnect BSP discrete
 	apic

Cyrill Gorcunov wrote:
> On 7/9/09, H. Peter Anvin <hpa@...or.com> wrote:
>> Cyrill Gorcunov wrote:
>>> In case of discrete APIC cpu_has_apic could be not set.
>>> This leads to disconnect_bsp_APIC is not called where
>>> it should.
>> I thought we were going to turn on cpu_has_apic in this case?
>>
>> 	-hpa
>>
>>
> Yes, this is just a temporary fix. I'll remove this snippet as only
> cpu-has-apic patch will be ready (i need to re-check all ways and and
> i need some time for this. Hope will finish it at weekend). Dunno
> Peter. If there is no urgency -- lets mark that we have this temporary
> workaround in lklm and if we get kind of bugreport we could apply the
> patch shortly :)


Since discrete-APIC systems are so old and rare I think it can wait for
the proper fix, however, as you said, if there are unexpected problems
we can reconsider.

	-hpa


-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/