linux-kernel - Re: [PATCH 41/44] includecheck fix: include/linux, rfkill.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1247118462.9709.36.camel@localhost.localdomain>
Date:	Wed, 08 Jul 2009 22:47:42 -0700
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Jaswinder Singh Rajput <jaswinder@...nel.org>
Cc:	johannes@...solutions.net, linux-wireless@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Sam Ravnborg <sam@...nborg.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 41/44] includecheck fix: include/linux, rfkill.h

Hi Jaswinder,

> > > fix the following 'make includecheck' warning:
> > > 
> > >   include/linux/rfkill.h: linux/types.h is included more than once.
> > > 
> > > Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...il.com>
> > > ---
> > >  include/linux/rfkill.h |    1 -
> > >  1 files changed, 0 insertions(+), 1 deletions(-)
> > > 
> > > diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
> > > index e73e242..2ce2983 100644
> > > --- a/include/linux/rfkill.h
> > > +++ b/include/linux/rfkill.h
> > > @@ -99,7 +99,6 @@ enum rfkill_user_states {
> > >  #undef RFKILL_STATE_UNBLOCKED
> > >  #undef RFKILL_STATE_HARD_BLOCKED
> > >  
> > > -#include <linux/types.h>
> > >  #include <linux/kernel.h>
> > >  #include <linux/list.h>
> > >  #include <linux/mutex.h>
> > 
> > with the #ifdef __KERNEL__ in between it is kinda weird, but patch seems
> > correct.
> > 
> 
> ACK or Reviewed-by ?

both if you want to, but John already picked it up for wireless-testing
if I am not mistaken. So it is on its way into 2.6.32 somehow.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/