linux-kernel - Re: [PATCH 11/12] SFI, PCI: Hook MMCONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090710151753.05848348@feng-desktop>
Date:	Fri, 10 Jul 2009 15:17:53 +0800
From:	Feng Tang <feng.tang@...el.com>
To:	Ingo Molnar <mingo@...e.hu>
CC:	Len Brown <lenb@...nel.org>, "x86@...nel.org" <x86@...nel.org>,
	"sfi-devel@...plefirmware.org" <sfi-devel@...plefirmware.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	Jesse Barnes <jbarnes@...tuousgeek.org>
Subject: Re: [PATCH 11/12] SFI, PCI: Hook MMCONFIG

On Fri, 10 Jul 2009 13:52:29 +0800
Ingo Molnar <mingo@...e.hu> wrote:

> 
> > @@ -606,7 +607,9 @@ static void __init __pci_mmcfg_init(int early)
> >  	}
> >  
> >  	if (!known_bridge)
> > -		acpi_table_parse(ACPI_SIG_MCFG, pci_parse_mcfg);
> > +		if (acpi_table_parse(ACPI_SIG_MCFG,
> > pci_parse_mcfg))
> > +			sfi_acpi_table_parse(ACPI_SIG_MCFG, NULL,
> > NULL, 0,
> > +				pci_parse_mcfg);
> 
> Please introduce one common/generic helper:
> 
> 		x86_table_parse(ACPI_SIG_MCFG, pci_parse_mcfg);
> 
> and do the fallback in that helper. We generally want to try ACPI 
> first, SFI second. That helper makes it easier to add such fallback 
> in other places as well, and will de-uglify the above code as well.
>

Should we have a new acpi_sfi.c or .h to contain all these helper functions?
I think it is not appropriate to put it to either ACPI or SFI code.

Also, ACPI and SFI code under arch/x86/kernel have lots of similar code
in cpu/io-apic parsing, we thought about extracting these sharable codes
out and move them to apic.c/io_apic.c, but don't know if this will
uglify current apic/ioapic code? how do you think about it?

Thanks,
Feng 
 
> 	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/