linux-kernel - Re: [PATCH] This is the security processor driver for the Intel mid platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090709232139.GF1469@ucw.cz>
Date:	Fri, 10 Jul 2009 01:21:39 +0200
From:	Pavel Machek <pavel@....cz>
To:	Mark Allyn <mark.a.allyn@...el.com>
Cc:	linux-kernel@...r.kernel.org, alan@...ux.intel.com,
	charles.f.johnson@...el.com
Subject: Re: [PATCH] This is the security processor driver for the Intel
	mid platform


> + *
> + *  CHANGES:
> + *
> + *  2009.06.26	Initial publish
> + * 
> + */

No changelogs in source files, please...

> +
> +  /* start address of resident */

Eh?

> +  unsigned long   message_size_in_words;
> +
> +};

> +struct sep_driver_realloc_cache_resident_t {
> +  /* base address */
> +  unsigned long   base_addr;

Most useless comment, ever.

> +  /* cache size in bytes*/
> +  unsigned long   cache_size_in_bytes;

...and more.
 
> +  /* new resident address */
> +  unsigned long   new_resident_addr;
> +
> +  /* new resident address */
> +  unsigned long   new_shared_area_addr;

Ouch. Copy & paste error?

> +  /* new base address */
> +  unsigned long   new_base_addr;

Did they tell you you have to document it, so you did? Bad comments
 are worse than no comments...  
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/