linux-kernel - Re: [PATCH for-2.6.32] sound dapm: fix checking for external widgets bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090710191925.GA5916@sirena.org.uk>
Date:	Fri, 10 Jul 2009 20:19:26 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Rongrong Cao <rrcao@...arella.com>
Cc:	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	trivial@...nel.org
Subject: Re: [PATCH for-2.6.32] sound dapm: fix checking for external
 widgets bug

On Tue, Jul 07, 2009 at 11:11:46PM -0700, Rongrong Cao wrote:
> From: Rongrong Cao rrcao@...arella.com

> This patch is based on for-2.6.32
> In SOC DAPM layer of SOUND subsystem, when add signal route (in the function snd_soc_dapm_add_route() ), 
> the original code has wrong logic when dapm layer check each widget whether an external one.

This still doesn't apply.  It looks like your MUA is corrupting the
patch - it's MIME encoded everything and replaced all the tabs with
spaces which is causing all the patch application programs I have to get
confused.  Documentation/email-clients.txt has some suggestions on how
to configure various MUAs to send patches cleanly.  Personally I always
use git send-email.  You probably also want to have a look at the
instructions in Documentation/SubmittingPatches with regard to the
formatting of your patch - the main thing being that the Signed-off-by
should go before the patch content.

In any case, I've manually applied the patch so no need to resubmit it.

I also notice that you've CCed trivial@...nel.org.  Please don't do that
except for things that can't possibly cause bugs - a change like this
doesn't really qualify since while the code clearly looks buggy it's
always possible that the code is just obscure.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/