linux-kernel - Re: [PATCH 1/1 tip] perf report: Adjust column width to the values sampled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090710040104.GB5077@elte.hu>
Date:	Fri, 10 Jul 2009 06:01:04 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Arnaldo Carvalho de Melo <acme@...hat.com>
Cc:	Frederic Weisbecker <fweisbec@...il.com>,
	Mike Galbraith <efault@....de>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1 tip] perf report: Adjust column width to the values
	sampled


* Arnaldo Carvalho de Melo <acme@...hat.com> wrote:

> Example:
> 
> [acme@...pio pahole]$  perf report --sort comm,dso,symbol | head -13
> 
>     12.79%   pahole  /usr/lib64/libdw-0.141.so    [.] __libdw_find_attr
>      8.90%   pahole  /lib64/libc-2.10.1.so        [.] _int_malloc
>      8.68%   pahole  /usr/lib64/libdw-0.141.so    [.] __libdw_form_val_len
>      8.15%   pahole  /lib64/libc-2.10.1.so        [.] __GI_strcmp
>      6.80%   pahole  /lib64/libc-2.10.1.so        [.] __tsearch
>      5.54%   pahole  ./build/libdwarves.so.1.0.0  [.] tag__recode_dwarf_type
> [acme@...pio pahole]$
> 
> [acme@...pio pahole]$  perf report --sort comm,dso,symbol -d /lib64/libc-2.10.1.so | head -10
> 
>     21.92%   pahole  /lib64/libc-2.10.1.so  [.] _int_malloc
>     20.08%   pahole  /lib64/libc-2.10.1.so  [.] __GI_strcmp
>     16.75%   pahole  /lib64/libc-2.10.1.so  [.] __tsearch
> [acme@...pio pahole]$
> 
> Cc: Frederic Weisbecker <fweisbec@...il.com>
> Cc: Mike Galbraith <efault@....de>
> Cc: Paul Mackerras <paulus@...ba.org>
> Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Suggested-by: Ingo Molnar <mingo@...e.hu>
> Signed-off-by: Arnaldo Carvalho de Melo <acme@...hat.com>
> ---
>  tools/perf/builtin-report.c            |   93 ++++++++++++++++++++++++--------
>  tools/perf/util/include/linux/kernel.h |    8 +++
>  tools/perf/util/symbol.c               |    1 +
>  tools/perf/util/symbol.h               |    1 +
>  4 files changed, 80 insertions(+), 23 deletions(-)

Ok, that's certainly a nice feature.

The only worry is that this makes it harder to post-process the 
output via scripts. Mind eliminating this worry and completing this 
patch by adding two other variants of this as well:

  -w, --field-width=<COLS>

  Force column width to <COLS>, for large terminal readability.

  ( Optional: perhaps also allow for special syntax -w 10,20,10 for
    separate width for separate columns. )

  -t, --field-separator=<SEP>

  Use special separator character <SEP> and dont pad with spaces, 
  and replace all occurances of '<SEP>' in symbol names (and other 
  output) with a '.' character.

  This is for easier output parsing for scripts.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/