linux-kernel - Re: [PATCH 2/2] tracing/kmemtrace: Use the %pf format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A56CEF8.8040106@cn.fujitsu.com>
Date:	Fri, 10 Jul 2009 13:17:44 +0800
From:	Li Zefan <lizf@...fujitsu.com>
To:	Frederic Weisbecker <fweisbec@...il.com>
CC:	Ingo Molnar <mingo@...e.hu>, LKML <linux-kernel@...r.kernel.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Lai Jiangshan <laijs@...fujitsu.com>,
	Pekka Enberg <penberg@...helsinki.fi>,
	Eduard - Gabriel Munteanu <eduard.munteanu@...ux360.ro>
Subject: Re: [PATCH 2/2] tracing/kmemtrace: Use the %pf format

Frederic Weisbecker wrote:
> Remove the obsolete seq_print_ip_sym() usage and replace it
> by the %pf format in order to print function symbols.
> 
> Signed-off-by: Frederic Weisbecker <fweisbec@...il.com>

Reviewed-by: Li Zefan <lizf@...fujitsu.com>

...

> -	/* Skip node */
> -	ret = trace_seq_printf(s, "       ");
> +	/* Skip node and print call site*/

a nitpick:

missing a space before '*/'

> +	ret = trace_seq_printf(s, "       %pf\n", (void *)entry->call_site);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/