linux-kernel - Re: [PATCH 02/12] SFI, x86: add CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090710052306.GC22218@elte.hu>
Date:	Fri, 10 Jul 2009 07:23:06 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Len Brown <lenb@...nel.org>
Cc:	x86@...nel.org, sfi-devel@...plefirmware.org,
	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
	Feng Tang <feng.tang@...el.com>,
	Len Brown <len.brown@...el.com>
Subject: Re: [PATCH 02/12] SFI, x86: add CONFIG_SFI


* Len Brown <lenb@...nel.org> wrote:

> +++ b/drivers/sfi/Kconfig
> @@ -0,0 +1,16 @@
> +#
> +# SFI Configuration
> +#
> +
> +menuconfig SFI
> +	bool "SFI (Simple Firmware Interface) Support"
> +	depends on X86

Instead of 'depends on X86' it's cleaner to add a HAVE_ARCH_SFI 
Kconfig variable to arch/x86/Kconfig, and turn the above into:

	depends on HAVE_ARCH_SFI

That will make it easier to enable it on other architectures such as 
IA64, should the need arise - and it's cleaner in any case.

> +	default n

Kconfig uses 'default n' by default, so this line can be left out.

> +	---help---
> +	The Simple Firmware Interface (SFI) provides a lightweight method
> +	for platform firmware to pass information to the Operating System
> +	via static tables in memory.
> +
> +	For more information, see http://simplefirmware.org
> +
> +	Say 'Y' here to enable the kernel to boot on SFI-only platforms.

Nitpick: s/Operating System/Linux kernel

(and even if we want to formulate it in a general way, it should be 
'operating system')

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/