linux-kernel - Re: [tip:x86/cleanups] x86/cpu: Clean up various files a bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 11 Jul 2009 15:10:28 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Jaswinder Singh Rajput <jaswinder@...nel.org>
Cc:	mingo@...hat.com, hpa@...or.com, alan@...ux.intel.com,
	linux-kernel@...r.kernel.org, tglx@...utronix.de, mingo@...e.hu,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/cleanups] x86/cpu: Clean up various files a bit

> > No code changes except printk levels (although some of the K6
> > mtrr code might be clearer if there were a few as would
> > splitting out some of the intel cache code).
> > -#include <asm/io.h>
> > +#include <linux/io.h>
> 
> linux/io.h should move to linux/XXX.h block

That would be a code change and potentially a behaviour change - it
should be done but as a later patch. It doesn't help that checkpatch is
buggy here and thinks some stuff is the same which is not.


> >  #if !defined(CONFIG_SMP)
> > -	printk("CPU: ");
> > +	printk(KERN_INFO "CPU: ");
> >  	print_cpu_info(&boot_cpu_data);
> >  #endif
> >  	alternative_instructions();
> 
> I think, these was left intentionally otherwise dmesg output looks
> weird.

Curious. If it is meant to be a continuation it should be KERN_CONT but
that doesn't seem to be the case. No KERN_ is wrong, always.

> >  	 * All current models of Pentium and Pentium with MMX technology CPUs
> > -	 * have the F0 0F bug, which lets nonprivileged users lock up the system.
> > +	 * have the F0 0F bug, which lets nonprivileged users lock up the
> > +	 * system.
> 
> It should be non-privileged

Yes - I agree (or better yet unprivileged)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/