linux-kernel - Re: [Bug #13337] [post 2.6.29 regression] hang during suspend of b44/b43 modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1247322985.30647.108.camel@johannes.local>
Date:	Sat, 11 Jul 2009 16:36:25 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Jan Scholz <scholz@...s.uni-frankfurt.de>
Cc:	"Rafael J. Wysocki" <rjw@...k.pl>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Kernel Testers List <kernel-testers@...r.kernel.org>,
	Tomas Janousek <tomi@...i.cz>,
	"John W. Linville" <linville@...driver.com>
Subject: Re: [Bug #13337] [post 2.6.29 regression] hang during suspend of
 b44/b43 modules

On Sat, 2009-07-11 at 16:07 +0200, Jan Scholz wrote:

> > Jan, can you run with console_suspend=0 (or whatever it is now, Rafael
> > will correct me if I'm wrong) that should work on your platform, and put
> > a bunch of printk calls into __ieee80211_suspend in net/mac80211/pm.c to
> > see where in there it's hanging?
> 
> Did that, seems like it hangs in
>   drv_remove_interface(local, &conf);

Ok, thanks! I was going to suggest doing the same in
b43_op_remove_interface in drivers/net/wireless/b43/main.c, but I think
the problem is just that we have an ordering problem and call drv_stop
before drv_remove_interface. I'll try to come up with a fix soon --
might not be able to today though, in the meantime I guess you can just
move the drv_stop call to the end of the function and tell me if that
works -- that would be racy but should be ok most of the time.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)