linux-kernel - Re: once again, what's with "drivers/char/vr41xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090711013212.GA1252@sucs.org>
Date:	Sat, 11 Jul 2009 02:32:12 +0100
From:	Andrew Price <andy@...rewprice.me.uk>
To:	"Robert P. J. Day" <rpjday@...shcourse.ca>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: once again, what's with "drivers/char/vr41xx_giu.c"?

Hi Robert,

On Fri, Jul 10, 2009 at 05:06:49AM -0400, Robert P. J. Day wrote:
> 
>   on an occasional basis (after pulls), i get:
> 
> $ git diff
> diff --git a/drivers/char/vr41xx_giu.c b/drivers/char/vr41xx_giu.c
> deleted file mode 100644
> index e69de29..0000000
> $
> 
> not the first time i've seen that, either.  methinks that file got
> itself into a funny state.

No need to panic, it just looks like somebody left an empty file without
'git rm'ing it. When you run 'make distclean' for example, it removes
all empty files and leaves you with an unclean checkout. You can get the
(empty) file back by 'git checkout'ing the file. But yes, you shouldn't
have to. Anyway, CCing Linus to bring it to his attention.

I wonder if there is a better way to avoid this happening? If 'make
distclean' is assuming that no files should be empty then there should
probably be a guard against introducing empty files in the first place.
Can git warn us when we commit or merge changes which leave empty files,
for instance?

Andrew
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/