[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1247345591-22643-10-git-send-email-u.kleine-koenig@pengutronix.de>
Date: Sat, 11 Jul 2009 22:52:38 +0200
From: Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>
To: Greg KH <gregkh@...e.de>, linux-kernel@...r.kernel.org
Cc: Russell King <rmk+kernel@....linux.org.uk>,
Krzysztof Helt <krzysztof.h1@...pl>,
Antonino Daplas <adaplas@...il.com>,
Andrew Morton <akpm@...ux-foundation.org>,
Paul Mundt <lethal@...ux-sh.org>,
Roland Stigge <stigge@...com.de>,
Greg Kroah-Hartman <gregkh@...e.de>
Subject: [PATCH] move epson1355fb's probe function to .devinit.text
A pointer to epson1355fb_probe is passed to the core via
platform_driver_register and so the function must not disappear when the
.init sections are discarded. Otherwise (if also having HOTPLUG=y)
unbinding and binding a device to the driver via sysfs will result in an
oops as does a device being registered late.
An alternative to this patch is using platform_driver_probe instead of
platform_driver_register plus removing the pointer to the probe function
from the struct platform_driver.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc: Russell King <rmk+kernel@....linux.org.uk>
Cc: Krzysztof Helt <krzysztof.h1@...pl>
Cc: Antonino Daplas <adaplas@...il.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>
Cc: Paul Mundt <lethal@...ux-sh.org>
Cc: Roland Stigge <stigge@...com.de>
Cc: Greg Kroah-Hartman <gregkh@...e.de>
---
drivers/video/epson1355fb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/epson1355fb.c b/drivers/video/epson1355fb.c
index 2735b79..6d755bb 100644
--- a/drivers/video/epson1355fb.c
+++ b/drivers/video/epson1355fb.c
@@ -602,7 +602,7 @@ static int epson1355fb_remove(struct platform_device *dev)
return 0;
}
-int __init epson1355fb_probe(struct platform_device *dev)
+int __devinit epson1355fb_probe(struct platform_device *dev)
{
struct epson1355_par *default_par;
struct fb_info *info;
--
1.6.3.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists