linux-kernel - Re: [PATCH] x86: Remove spurious printk level from segfault message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 11 Jul 2009 09:57:21 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Roland Dreier <roland@...italvampire.org>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: Remove spurious printk level from segfault message


* Roland Dreier <roland@...italvampire.org> wrote:

> Since commit 5fd29d6c ("printk: clean up handling of log-levels and
> newlines"), the kernel logs segfaults like:
> 
>     <6>gnome-power-man[24509]: segfault at 20 ip 00007f9d4950465a sp 00007fffbb50fc70 error 4 in libgobject-2.0.so.0.2103.0[7f9d494f7000+45000]
> 
> with the extra "<6>" being KERN_INFO.  This happens because the printk
> in show_signal_msg() started with KERN_CONT and then used "%s" to pass
> in the real level; and KERN_CONT is no longer an empty string, and
> printk only pays attention to the level at the very beginning of the
> format string.
> 
> Therefore, remove the KERN_CONT from this printk, since it is now
> actively causing problems (and never really made any sense).

Indeed, this particular KERN_CONT never made any sense. It's good it 
has some active role now. Applied to tip:x86/urgent, thanks Roland.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/