linux-kernel - Re: [PATCH 5/5] staging/otus: Move a dereference below a NULL test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A584A94.5010105@gmail.com>
Date:	Sat, 11 Jul 2009 10:17:24 +0200
From:	Jiri Slaby <jirislaby@...il.com>
To:	Julia Lawall <julia@...u.dk>
CC:	gregkh@...e.de, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 5/5] staging/otus: Move a dereference below a NULL test

On 07/11/2009 09:51 AM, Julia Lawall wrote:
> diff -u -p a/drivers/staging/otus/wwrap.c b/drivers/staging/otus/wwrap.c
> --- a/drivers/staging/otus/wwrap.c
> +++ b/drivers/staging/otus/wwrap.c
> @@ -1016,12 +1016,13 @@ void kevent(struct work_struct *work)
>  {
>      struct usbdrv_private *macp =
>                 container_of(work, struct usbdrv_private, kevent);
> -    zdev_t *dev = macp->device;
> +    zdev_t *dev;
>  
>      if (macp == NULL)
>      {
>          return;
>      }

The test is rather useless here.

> +    dev = macp->device;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/