linux-kernel - Re: [PATCH v2 for 2.6.32] SFI - Simple Firmware Interface support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <alpine.LFD.2.00.0907102059320.4088@localhost.localdomain>
Date:	Fri, 10 Jul 2009 21:01:25 -0400 (EDT)
From:	Len Brown <lenb@...nel.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	x86@...nel.org, sfi-devel@...plefirmware.org,
	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org
Subject: Re: [PATCH v2 for 2.6.32] SFI - Simple Firmware Interface support


> 
> > Feng Tang (10):
> >       SFI, x86: add CONFIG_SFI
> >       SFI: document boot param "sfi=off"
> >       SFI: create include/linux/sfi.h
> >       SFI: add core support
> >       ACPI, x86: remove ACPI dependency on some IO-APIC routines
> >       SFI: add x86 support
> >       SFI, x86: hook e820() for memory map initialization
> >       SFI: Enable SFI to parse ACPI tables
> >       SFI, PCI: Hook MMCONFIG
> >       SFI: add boot-time initialization hooks
> 
> Now that commit quality is all the rage, let me point out a 
> (trivial) detail that could be improved: patch title capitalization. 
> 
> In particular for commits touching arch/x86/ we try to standardize 
> on capitalizing the word after the 'x86: ' tag. But in the above 
> titles the capitalization is mixed-case:
> 
>  [aligned vertically for easier readability ]
> 
> >       SFI, x86:  add CONFIG_SFI
> >       SFI:       document boot param "sfi=off"
> >       SFI:       create include/linux/sfi.h
> >       SFI:       add core support
> >       ACPI, x86: remove ACPI dependency on some IO-APIC routines
> >       SFI:       add x86 support
> >       SFI, x86:  hook e820() for memory map initialization
> >       SFI:       Enable SFI to parse ACPI tables
> >       SFI, PCI:  Hook MMCONFIG
> >       SFI:       add boot-time initialization hooks
> 
> So it would be more consistent to have:
> 
> >       SFI, x86:  Add CONFIG_SFI
> >       SFI:       Document boot param "sfi=off"
> >       SFI:       Create include/linux/sfi.h
> >       SFI:       Add core support
> >       ACPI, x86: Remove ACPI dependency on some IO-APIC routines
> >       SFI:       Add x86 support
> >       SFI, x86:  Hook e820() for memory map initialization
> >       SFI:       Enable SFI to parse ACPI tables
> >       SFI, PCI:  Hook MMCONFIG
> >       SFI:       Add boot-time initialization hooks
> 
> ( Capitalizing like that has the added (minor) benefit of making it 
>   slightly easier to read these titles - the 'real' natural language 
>   sentence portion of the title begins with a capital letter. )

Ingo,
While I really do appreciate your attention to detail,
a little time off might be good for you:-)

cheers,
-Len

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/