linux-kernel - Re: [PATCH] move sb1250-mac's probe function to .devinit.text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0907120135500.13862@eddie.linux-mips.org>
Date:	Sun, 12 Jul 2009 01:36:56 +0100 (BST)
From:	"Maciej W. Rozycki" <macro@...ux-mips.org>
To:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
cc:	Greg KH <gregkh@...e.de>, linux-kernel@...r.kernel.org,
	Weiwei Wang <weiwei.wang@...driver.com>,
	Jeff Garzik <jgarzik@...hat.com>,
	"David S. Miller" <davem@...emloft.net>,
	Stephen Hemminger <shemminger@...tta.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] move sb1250-mac's probe function to .devinit.text

On Sat, 11 Jul 2009, Uwe Kleine-K?nig wrote:

> A pointer to sbmac_probe is passed to the core via
> platform_driver_register and so the function must not disappear when the
> .init sections are discarded.  Otherwise (if also having HOTPLUG=y)
> unbinding and binding a device to the driver via sysfs will result in an
> oops as does a device being registered late.
> 
> An alternative to this patch is using platform_driver_probe instead of
> platform_driver_register plus removing the pointer to the probe function
> from the struct platform_driver.
> 
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@...gutronix.de>
> Cc: Weiwei Wang <weiwei.wang@...driver.com>
> Cc: Jeff Garzik <jgarzik@...hat.com>
> Cc: David S. Miller <davem@...emloft.net>
> Cc: Stephen Hemminger <shemminger@...tta.com>
> Cc: Maciej W. Rozycki <macro@...ux-mips.org>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> ---
>  drivers/net/sb1250-mac.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Acked-by: Maciej W. Rozycki <macro@...ux-mips.org>

 Fine by me, thanks.

  Maciej
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/