linux-kernel - Re: [PATCH v3 04/18] EXOFS: do not manipulate s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A59B2AB.9010900@panasas.com>
Date:	Sun, 12 Jul 2009 12:53:47 +0300
From:	Boaz Harrosh <bharrosh@...asas.com>
To:	Artem Bityutskiy <Artem.Bityutskiy@...ia.com>
CC:	Al Viro <viro@...IV.linux.org.uk>,
	Jens Axboe <jens.axboe@...cle.com>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	Jeff Garzik <jeff@...zik.org>
Subject: Re: [PATCH v3 04/18] EXOFS: do not manipulate s_dirt directly

On 07/09/2009 11:48 AM, Artem Bityutskiy wrote:
> ... use new VFS helpers instead.
> 
> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@...ia.com>
> Acked-by: Boaz Harrosh <bharrosh@...asas.com>

Hi Artem.

Linus has pulled the exofs tree for 2.6.31-rc3 if you sync
with it you'll find one more simple call site for is_sb_dirty(sb).
(See below)

Thanks
Boaz

---
git diff --stat -p fs/exofs/file.c
 fs/exofs/file.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/exofs/file.c b/fs/exofs/file.c
index 839b9dc..be38834 100644
--- a/fs/exofs/file.c
+++ b/fs/exofs/file.c
@@ -58,7 +58,7 @@ static int exofs_file_fsync(struct file *filp, struct dentry *dentry,
 	/* This is a good place to write the sb */
 	/* TODO: Sechedule an sb-sync on create */
 	sb = inode->i_sb;
-	if (sb->s_dirt)
+	if (is_sb_dirty(sb))
 		exofs_sync_fs(sb, 1);
 
 	return ret;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/