linux-kernel - [PATCH 2/2] net/irda/ircomm: Drop unnecessary NULL test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0907131210070.6808@ask.diku.dk>
Date:	Mon, 13 Jul 2009 12:10:32 +0200 (CEST)
From:	Julia Lawall <julia@...u.dk>
To:	samuel@...tiz.org, irda-users@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: [PATCH 2/2] net/irda/ircomm: Drop unnecessary NULL test

From: Julia Lawall <julia@...u.dk>

The result of container_of should not be NULL.  In particular, in this case
the argument to the enclosing function has passed though INIT_WORK,
which dereferences it, implying that its container cannot be NULL.

The semantic match that finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
expression x,e;
@@

x = container_of(...)
... when != x = e
* x == NULL
// </smpl>

Signed-off-by: Julia Lawall <julia@...u.dk>

---
 net/irda/ircomm/ircomm_tty.c        |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/irda/ircomm/ircomm_tty.c b/net/irda/ircomm/ircomm_tty.c
index 811984d..6306c19 100644
--- a/net/irda/ircomm/ircomm_tty.c
+++ b/net/irda/ircomm/ircomm_tty.c
@@ -609,7 +609,7 @@ static void ircomm_tty_do_softint(struct work_struct *work)
 
 	IRDA_DEBUG(2, "%s()\n", __func__ );
 
-	if (!self || self->magic != IRCOMM_TTY_MAGIC)
+	if (self->magic != IRCOMM_TTY_MAGIC)
 		return;
 
 	tty = self->tty;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/