linux-kernel - Re: [PATCH 04/10] percpu: make 4k first chunk allocator map memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <24253.1247479973@redhat.com>
Date:	Mon, 13 Jul 2009 11:12:53 +0100
From:	David Howells <dhowells@...hat.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	dhowells@...hat.com, linux-kernel@...r.kernel.org, x86@...nel.org,
	linux-arch@...r.kernel.org, mingo@...e.hu, andi@...stfloor.org,
	hpa@...or.com, tglx@...utronix.de, cl@...ux-foundation.org,
	akpm@...ux-foundation.org
Subject: Re: [PATCH 04/10] percpu: make 4k first chunk allocator map memory

Tejun Heo <tj@...nel.org> wrote:

> +	pr_info("PERCPU: %d 4k pages per cpu, static data %zu bytes\n",
> +		pcpu4k_unit_pages, static_size);

It occurs to me that this is may include a bad assumption.  Page size need not
be 4K.  I don't know that it matters, but looking at this:

> +	vm.size = num_possible_cpus() * pcpu4k_unit_pages << PAGE_SHIFT;
> +	vm_area_register_early(&vm, PAGE_SIZE);

It might.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/