linux-kernel - Re: [rfc][patch 3/4] fs: new truncate sequence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090713113206.GB3452@wotan.suse.de>
Date:	Mon, 13 Jul 2009 13:32:06 +0200
From:	Nick Piggin <npiggin@...e.de>
To:	Boaz Harrosh <bharrosh@...asas.com>
Cc:	Christoph Hellwig <hch@...radead.org>,
	linux-fsdevel@...r.kernel.org, Jan Kara <jack@...e.cz>,
	LKML <linux-kernel@...r.kernel.org>, linux-mm@...ck.org
Subject: Re: [rfc][patch 3/4] fs: new truncate sequence

On Mon, Jul 13, 2009 at 02:17:55PM +0300, Boaz Harrosh wrote:
> On 07/13/2009 12:00 PM, Nick Piggin wrote:
> > AFAIKS inode_setattr basically is simple_setattr, so I think at some
> > point it should just get renamed to simple_setattr. Adding
> > simple_setattr_nosize or similar helper would be fine too. I don't
> > care much about the exact details... But anyway these things are not
> > so important to this truncate patchset at the moment.
> > 
> 
> I see. So what is the schedule? when are we to convert all FSs?

Well the changes can be back compatible, and there is not too
much complexity to support the current system, so I guess it
will just be done as soon as somebody writes the patches.

But probably it is a good idea to convert any filesystem using
->truncate to the new sequence at the same time (ie. don't
just simply add .setattr = simple_setattr, and rely on its calling
vmtruncate, but actually DTRT and remove .truncate at the
same time).

Any patches would be welcome, for any filesystem. Probably it
won't exactly be a rapid process, judging by past experience.


> >> [BTW these changes are a life saver for me in regard to
> >> the kind of things I need to do for pNFS-exports]
> > 
> > You mean the truncate patches? Well that's nice to know. I
> > guess it has always been possible just to redefine your own
> > setattr, but now it should be a bit nicer with the truncate
> > helpers...
> > 
> 
> OK, yes redefine .setattr, do the right thing in write_begin/end
> and the helpers do help a lot, to the point that it was not safe to
> open-code all this work. The situation is much better after your
> patchset.

OK good.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/