linux-kernel - [RFC][PATCH] taskstats: Fix CGROUPSTATS_TYPE_CGROUP_STATS having same value as TASKSTATS_TYPE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <200907131831.12994.knikanth@suse.de>
Date:	Mon, 13 Jul 2009 18:31:12 +0530
From:	Nikanth Karthikesan <knikanth@...e.de>
To:	balbir@...ux.vnet.ibm.com
Cc:	Paul Menage <menage@...gle.com>, lizf@...fujitsu.com,
	linux-kernel@...r.kernel.org
Subject: [RFC][PATCH] taskstats: Fix CGROUPSTATS_TYPE_CGROUP_STATS having same value as TASKSTATS_TYPE_PID

Hi

Currently we never get message from kernel to userspace of type 
TASKSTATS_TYPE_PID. Otherwise this could have been spotted earlier.

I was trying to add a new taskstat command that would return response of type 
TASKSTATS_TYPE_PID.

Having the same values would restrict one not to use the same netlink socket 
for a command that would return response of type TASKSTATS_TYPE_PID and the 
CGROUPSTATS_CMD_GET command.

Should we fix it by using values after __TASKSTATS_TYPE_MAX.

Changing this now might break pre-built binaries. Or is this intended, and the 
application is not supposed to use CGROUPSTATS and TASKSTATS on the same 
socket? 

Thanks
Nikanth

Currently we never get message from kernel to userspace of type 
TASKSTATS_TYPE_PID. Otherwise this could have been spotted earlier. Having the 
values in the same range would restrict one not to use the same netlink socket 
for a command that would return response of type TASKSTATS_TYPE_PID and the 
CGROUPSTATS_CMD_GET command. Fix it by using values after 
__TASKSTATS_TYPE_MAX.

Signed-off-by: Nikanth Karthikesan <knikanth@...e.de>

---

diff --git a/include/linux/cgroupstats.h b/include/linux/cgroupstats.h
index 3753c33..87b31f0 100644
--- a/include/linux/cgroupstats.h
+++ b/include/linux/cgroupstats.h
@@ -53,7 +53,7 @@ enum {
 #define CGROUPSTATS_CMD_MAX (__CGROUPSTATS_CMD_MAX - 1)

 enum {
-	CGROUPSTATS_TYPE_UNSPEC = 0,	/* Reserved */
+	CGROUPSTATS_TYPE_UNSPEC = __TASKSTATS_TYPE_MAX,	/* Reserved */
 	CGROUPSTATS_TYPE_CGROUP_STATS,	/* contains name + stats */
 	__CGROUPSTATS_TYPE_MAX,
 };

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/