linux-kernel - Re: linux-next: Tree for July 13 (staging/usbip)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090713100242.f09c044b.randy.dunlap@oracle.com>
Date:	Mon, 13 Jul 2009 10:02:42 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	lkml <linux-kernel@...r.kernel.org>
Cc:	Greg KH <gregkh@...e.de>, Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org
Subject: Re: linux-next: Tree for July 13 (staging/usbip)

On Mon, 13 Jul 2009 09:34:43 -0700 Randy Dunlap wrote:

> On Mon, 13 Jul 2009 09:25:11 -0700 Greg KH wrote:
> 
> > On Mon, Jul 13, 2009 at 08:59:15AM -0700, Randy Dunlap wrote:
> > > On Mon, 13 Jul 2009 18:05:24 +1000 Stephen Rothwell wrote:
> > > 
> > > > Hi all,
> > > > 
> > > > Changes since 20090710:
> > > 
> > > 
> > > drivers/staging/usbip/usbip_common.c: In function 'usbip_thread':
> > > drivers/staging/usbip/usbip_common.c:386: error: implicit declaration of function 'lock_kernel'
> > > drivers/staging/usbip/usbip_common.c:390: error: implicit declaration of function 'unlock_kernel'
> > > 
> > > config attached.
> > 
> > Odd, that code has not changed at all.
> > 
> > Did we just loose the big kernel lock somehow?
> 
> I dunno.  Probably some header file cleanup thing.  :(
> 
> Looks like only linux/smp_lock.h #defines it, but a driver shouldn't
> need to #include that file IMHO.

Adding
#include <linux/smp_lock.h>
does fix the build error, but I don't like it.

---
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/