linux-kernel - Re: iwl: potential deadlock?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1247516320.17896.1640.camel@rc-desk>
Date:	Mon, 13 Jul 2009 13:18:40 -0700
From:	reinette chatre <reinette.chatre@...el.com>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	"Zhu, Yi" <yi.zhu@...el.com>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"ipw3945-devel@...ts.sourceforge.net" 
	<ipw3945-devel@...ts.sourceforge.net>,
	Linux kernel mailing list <linux-kernel@...r.kernel.org>
Subject: Re: iwl: potential deadlock?

Hi Jiri,

On Mon, 2009-07-13 at 12:34 -0700, Jiri Slaby wrote:
> Hi,
> 
> we found a potential deadlock in iwl code by our tool.

What tool is this?

> 
> Can this happen:

I don't think so ...

> iwl_update_tkip_key()
> -> spin_lock_irqsave(&priv->sta_lock)
> -> iwl_send_add_sta()

iwl_send_add_sta() is called here with flags = CMD_ASYNC

In iwl_send_add_sta() we have:
	if (ret || (flags & CMD_ASYNC))
		return ret;

>    -> iwl_sta_ucode_activate()

... so this is not run in this case.

>       -> spin_lock_irqsave(&priv->sta_lock)

Reinette

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/