linux-kernel - Re: [PATCH] hw_breakpoint: remove sample code from hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4A5AC5F5.5050206@cn.fujitsu.com>
Date:	Mon, 13 Jul 2009 13:28:21 +0800
From:	Li Zefan <lizf@...fujitsu.com>
To:	Frederic Weisbecker <fweisbec@...il.com>
CC:	Ingo Molnar <mingo@...e.hu>,
	Alan Stern <stern@...land.harvard.edu>,
	"K.Prasad" <prasad@...ux.vnet.ibm.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] hw_breakpoint: remove sample code from hw_breakpoint.h

(sorry for the late reply, I didn't see this mail..)

Frederic Weisbecker wrote:
> On Tue, Jul 07, 2009 at 01:40:11PM +0800, Li Zefan wrote:
>> The sample code is a bit out-dated, and there's already a
>> sample in sample/hw_breakpoint/.
> 
> 
> IMHO these bits of comments are useful and don't overlap the role
> of the samples in sample/
> They only stand there as a quick summup.
> 
> No?
> 

The sample here sets a breakpoint on pid_max, which is what the sample
in sample/ does.

And the code here is out-dated (and incomplete). We can fix it, but
whenver someone changes the APIs, he may forget to update the comments.
We know comments never catch up with code.

So I inclined to delete it, and add a link to sample/.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/