[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090713070248.GB28499@elte.hu>
Date: Mon, 13 Jul 2009 09:02:48 +0200
From: Ingo Molnar <mingo@...e.hu>
To: Ming Lei <tom.leiming@...il.com>
Cc: Frederic Weisbecker <fweisbec@...il.com>, a.p.zijlstra@...llo.nl,
linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [RESEND PATCH 0/11] kernel:lockdep:replace DFS with BFS
* Ming Lei <tom.leiming@...il.com> wrote:
> > I don't have a strong opinion on this. I just don't think the
> > shortest path is the most important if there are many many
> > paths. Whatever AB-BA is encountered, all of them must be fixed.
> > What might give a degree of importance for such bad circle is
> > the window in which it triggers.
>
> The shortest path is just a characteristic of BFS, and we do not
> need to pay extra work for it. So finding the shortest circle
> have not any bad effect at least.
>
> IMHO, troubleshooting from the shortest circle is easier than from
> other circle.
Agreed. Making lockdep reports more readable (i.e. smaller) is a
very important goal.
Often the longer circles are just a side-effect of the shorter
circles and fixing the short one will fix the large ones too. So
printing the smallest is an advantage IMO.
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists