linux-kernel - Re: [RFC PATCH] block: slightly optimize blkdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 14 Jul 2009 21:48:28 +0800
From:	Américo Wang <xiyou.wangcong@...il.com>
To:	Xiaotian Feng <dfeng@...hat.com>
Cc:	axboe@...nel.dk, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] block: slightly optimize blkdev_ioctl BLKRA{SET,GET}

On Tue, Jul 14, 2009 at 7:59 PM, Xiaotian Feng<dfeng@...hat.com> wrote:
> Slightly optimize blkdev_ioctl by using shift instead of multiply
> and divide.

Not necessary, I believe gcc can do this by itself.

Have you checked its asm code?

>
> Signed-off-by: Xiaotian Feng <dfeng@...hat.com>
> ---
>  block/ioctl.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/block/ioctl.c b/block/ioctl.c
> index 500e4c7..f8c7362 100644
> --- a/block/ioctl.c
> +++ b/block/ioctl.c
> @@ -305,7 +305,7 @@ int blkdev_ioctl(struct block_device *bdev, fmode_t mode, unsigned cmd,
>                bdi = blk_get_backing_dev_info(bdev);
>                if (bdi == NULL)
>                        return -ENOTTY;
> -               return put_long(arg, (bdi->ra_pages * PAGE_CACHE_SIZE) / 512);
> +               return put_long(arg, bdi->ra_pages << (PAGE_CACHE_SHIFT - 9));
>        case BLKROGET:
>                return put_int(arg, bdev_read_only(bdev) != 0);
>        case BLKBSZGET: /* get the logical block size (cf. BLKSSZGET) */
> @@ -321,7 +321,7 @@ int blkdev_ioctl(struct block_device *bdev, fmode_t mode, unsigned cmd,
>                bdi = blk_get_backing_dev_info(bdev);
>                if (bdi == NULL)
>                        return -ENOTTY;
> -               bdi->ra_pages = (arg * 512) / PAGE_CACHE_SIZE;
> +               bdi->ra_pages = arg >> (PAGE_CACHE_SHIFT - 9);
>                return 0;
>        case BLKBSZSET:
>                /* set the logical block size */
> --
> 1.6.2.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/