| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1247581062.28240.97.camel@pc1117.cambridge.arm.com> Date: Tue, 14 Jul 2009 15:17:42 +0100 From: Catalin Marinas <catalin.marinas@....com> To: Sergey Senozhatsky <sergey.senozhatsky@...l.by> Cc: Pekka Enberg <penberg@...helsinki.fi>, "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>, linux-kernel@...r.kernel.org, linux-mm@...ck.org Subject: Re: kmemleak hexdump proposal On Tue, 2009-07-14 at 17:03 +0300, Sergey Senozhatsky wrote: > On (07/14/09 14:39), Catalin Marinas wrote: > > On Tue, 2009-07-14 at 13:57 +0300, Sergey Senozhatsky wrote: > > [...] > > > +/* > > > + * Printing of the objects hex dump to the seq file. The number on lines > > > + * to be printed is limited to HEX_MAX_LINES to prevent seq file spamming. > > > + * The actual number of printed bytes depends on HEX_ROW_SIZE. > > > + * It must be called with the object->lock held. > > > + */ > > [...] > > > > The patch looks fine. Could you please add a description and > > Signed-off-by line? > > > > Sure. During 30-40 minutes (sorry, I'm a bit busy now). OK? There is no hurry, sometime in the next few weeks :-) > Should I update Documentation/kmemeleak.txt either? I don't think this is needed as it doesn't say much about the format of the debug/kmemleak file (and that's pretty clear, no need to explain what a hex dump means). -- Catalin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists