linux-kernel - Re: [PATCH 1/3] drivers/hid: Drop NULL test on list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.0907141717050.813@wotan.suse.de>
Date:	Tue, 14 Jul 2009 17:18:19 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Julia Lawall <julia@...u.dk>
Cc:	linux-input@...r.kernel.org, gregkh@...e.de, jirislaby@...il.com,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 1/3] drivers/hid: Drop NULL test on list_entry result

On Sun, 12 Jul 2009, Julia Lawall wrote:

> diff --git a/drivers/hid/hid-lgff.c b/drivers/hid/hid-lgff.c
> index 95835ea..987abeb 100644
> --- a/drivers/hid/hid-lgff.c
> +++ b/drivers/hid/hid-lgff.c
> @@ -151,11 +151,6 @@ int lgff_init(struct hid_device* hid)
>  
>  	/* Check that the report looks ok */
>  	report = list_entry(report_list->next, struct hid_report, list);
> -	if (!report) {
> -		err_hid("NULL output report");
> -		return -1;
> -	}
> -
>  	field = report->field[0];
>  	if (!field) {
>  		err_hid("NULL field");
> 

Applied, thanks Julia.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/