linux-kernel - Re: HTC: touchscreen driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1247536087.31854.39.camel@desktop>
Date:	Mon, 13 Jul 2009 18:48:07 -0700
From:	Daniel Walker <dwalker@...o99.com>
To:	Pavel Machek <pavel@....cz>
Cc:	Brian Swetland <swetland@...gle.com>,
	kernel list <linux-kernel@...r.kernel.org>
Subject: Re: HTC: touchscreen driver

On Tue, 2009-07-14 at 00:07 +0200, Pavel Machek wrote:
> On Mon 2009-07-13 22:57:49, Pavel Machek wrote:
> > Hi!
> > 
> > I'm looking at synaptic touchscreen driver... who should be listed as
> > an author?
> > 
> > Changes I have so far are...
> > 
> > checkpatch only has minor complains -- lines over 80 characters -- but
> > the code is _way_ too deeply nested with way too little functions.
> 
> Here's better cleanup. But... some functions are still _way_ too big.
> 

I'd put the nesting removal into another patch .. It makes reviewing
more clear, your first patch was already fairly busy .. It would also
make a bisect more fine grained if it lands on one of your patches.

Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/