linux-kernel - Re: [PATCH 3/3] eeepc-laptop: Update the backlight state when we change brightness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <71cd59b00907150240q22e8694el281cf862e71e1b66@mail.gmail.com>
Date:	Wed, 15 Jul 2009 11:40:08 +0200
From:	Corentin Chary <corentin.chary@...il.com>
To:	Matthew Garrett <mjg@...hat.com>
Cc:	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
	rpurdie@...ys.net, lenb@...nel.org, rui.zhang@...el.com
Subject: Re: [PATCH 3/3] eeepc-laptop: Update the backlight state when we 
	change brightness

On Tue, Jul 14, 2009 at 6:06 PM, Matthew Garrett<mjg@...hat.com> wrote:
> Trigger a status update when the user hits a brightness key, allowing
> userspace to present appropriate UI.
>
> Signed-off-by: Matthew Garrett <mjg@...hat.com>
> ---
>  drivers/platform/x86/eeepc-laptop.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/platform/x86/eeepc-laptop.c b/drivers/platform/x86/eeepc-laptop.c
> index ec560f1..fde86b3 100644
> --- a/drivers/platform/x86/eeepc-laptop.c
> +++ b/drivers/platform/x86/eeepc-laptop.c
> @@ -641,7 +641,7 @@ static int notify_brn(void)
>        struct backlight_device *bd = eeepc_backlight_device;
>        if (bd) {
>                int old = bd->props.brightness;
> -               bd->props.brightness = read_brightness(bd);
> +               backlight_force_update(bd, BACKLIGHT_UPDATE_HOTKEY);
>                return old;
>        }
>        return -1;
> --
> 1.6.2.5
>
>

This could be added to asus-laptop too. It doesn't handle brightness
changes right now (only backlight on/off) but it works the same way,
so it won't be hard to add. I'll do that as soon as your main patch is
merged.
Thanks,


-- 
Corentin Chary
http://xf.iksaif.net - http://uffs.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/