linux-kernel - Re: [PATCH] mm: Warn once when a page is freed with PG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.1.10.0907151027410.23643@gentwo.org>
Date:	Wed, 15 Jul 2009 10:31:54 -0400 (EDT)
From:	Christoph Lameter <cl@...ux-foundation.org>
To:	Mel Gorman <mel@....ul.ie>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	kosaki.motohiro@...fujitsu.com,
	Maxim Levitsky <maximlevitsky@...il.com>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	Lee Schermerhorn <Lee.Schermerhorn@...com>,
	Pekka Enberg <penberg@...helsinki.fi>,
	Johannes Weiner <hannes@...xchg.org>,
	Jiri Slaby <jirislaby@...il.com>
Subject: Re: [PATCH] mm: Warn once when a page is freed with PG_mlocked set
 V2

On Wed, 15 Jul 2009, Mel Gorman wrote:

> -static inline int free_pages_check(struct page *page)
> +static inline int free_pages_check(struct page *page, int wasMlocked)
>  {
> +	WARN_ONCE(wasMlocked, KERN_WARNING
> +		"Page flag mlocked set for process %s at pfn:%05lx\n"
> +		"page:%p flags:0x%lX\n",
> +		current->comm, page_to_pfn(page),
> +		page, page->flags|__PG_MLOCKED);
> +
>  	if (unlikely(page_mapcount(page) |

There is already a free_page_mlocked() that is only called if the mlock
bit is set. Move it into there to avoid having to run two checks in the
hot codee path?

Also __free_pages_ok() now has a TestClearMlocked in the hot code path.
Would it be possible to get rid of the unconditional use of an atomic
operation? Just check the bit and clear it later in free_page_mlocked()?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/