linux-kernel - Re: [BUG] set_mempolicy(MPOL_INTERLEAV) cause kernel panic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1247679064.4089.26.camel@useless.americas.hpqcorp.net>
Date:	Wed, 15 Jul 2009 13:31:04 -0400
From:	Lee Schermerhorn <Lee.Schermerhorn@...com>
To:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
Cc:	Miao Xie <miaox@...fujitsu.com>, Ingo Molnar <mingo@...e.hu>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Christoph Lameter <cl@...ux-foundation.org>,
	Paul Menage <menage@...gle.com>,
	Nick Piggin <nickpiggin@...oo.com.au>,
	Yasunori Goto <y-goto@...fujitsu.com>,
	Pekka Enberg <penberg@...helsinki.fi>,
	David Rientjes <rientjes@...gle.com>,
	linux-mm <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [BUG] set_mempolicy(MPOL_INTERLEAV) cause kernel panic

On Wed, 2009-07-15 at 18:48 +0900, KOSAKI Motohiro wrote:
> Hi
> 
> On 2.6.31-rc3, following test makes kernel panic immediately.
> 
>   numactl --interleave=all echo
> 
> Panic message is below. I don't think commit 58568d2a8 is correct patch.
> 
> old behavior:
>   do_set_mempolicy
>     mpol_new
>       cpuset_update_task_memory_state
>         guarantee_online_mems
>           nodes_and(cs->mems_allowed, node_states[N_HIGH_MEMORY]);
> 
> but new code doesn't consider N_HIGH_MEMORY. Then, the userland program
> passing non-online node bit makes crash, I guess.
> 
> Miao, What do you think?

This looks similar to the problem I tried to fix in:

	http://marc.info/?l=linux-mm&m=124140637722309&w=4

Miao pointed out that the patch needs more work to track hot plug of
nodes.  I've not had time to get back to this.

Interestingly, on ia64, the top cpuset mems_allowed gets set to all
possible nodes, while on x86_64, it gets set to on-line nodes [or nodes
with memory].  Maybe this is a to support hot-plug?

Lee

<snip>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/