linux-kernel - Re: HTC: touchscreen driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A5E2895.3040907@am.sony.com>
Date:	Wed, 15 Jul 2009 12:05:57 -0700
From:	Frank Rowand <frank.rowand@...sony.com>
To:	Pavel Machek <pavel@....cz>
CC:	Joe Perches <joe@...ches.com>,
	Arve Hjønnevåg <arve@...roid.com>,
	Brian Swetland <swetland@...gle.com>,
	kernel list <linux-kernel@...r.kernel.org>
Subject: Re: HTC: touchscreen driver

Joe Perches wrote:
> On Mon, 2009-07-13 at 18:29 -0700, Arve Hjønnevåg wrote:
>> On Mon, Jul 13, 2009 at 3:07 PM, Pavel Machek<pavel@....cz> wrote:
>>> -                       printk(KERN_ERR "synaptics_ts_work_func: i2c_transfer failed\n");
>>> +                       printk(KERN_ERR "ts_work: i2c_transfer failed\n");
>> This will make it harder to read the kernel logs since the driver is 
>> no longer specified.
> 
> How about converting to:
> 
> #define pr_fmt(fmt) KBUILD_MODNAME ":%s: " fmt, __func__
> or
> #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> 
> and pr_<level>()

dev_printk() and the related helpers in include/linux/device.h
might also be useful.

-Frank Rowand
---
Sony Corporation of America

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/