linux-kernel - Re: Kernel Oops when trying to suspend with ubifs mounted on block2mtd mtd device on 2.3.31-rc2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090715191558.GA18203@yamamaya.is-a-geek.org>
Date:	Wed, 15 Jul 2009 21:15:59 +0200
From:	Tobias Diedrich <ranma+kernel@...edrich.de>
To:	David Brownell <david-b@...bell.net>
Cc:	Adrian Hunter <adrian.hunter@...ia.com>,
	linux-kernel@...r.kernel.org, linux-mtd@...ts.infradead.org,
	David.Woodhouse@...el.com
Subject: Re: Kernel Oops when trying to suspend with ubifs mounted on
	block2mtd mtd device on 2.3.31-rc2

David Brownell wrote:
> On Wednesday 15 July 2009, Adrian Hunter wrote:
> > Looks like it might be related to MTD driver model updates.
> 
> Not the sysfs support ... more likely the patch adding cls_suspend()
> support, 15bce40cb3133bcc07d548013df97e4653d363c1, is goofed.  Maybe
> it's invoking suspend on the wrong device node...

Yes, that is the culprit.
AFAICS it uses the 'dev_to_mtd()' macro to get the mtd, but calls it
on itself instead of the child classes, so the resulting mtd device
pointer is bogus.

With some debug printks I get:

[...]
PM: Freed 0 kbytes in 0.06 seconds[...]
mtd_cls_suspend(f68e3180, 1)
dev->class->name = 'mtd'
callig mtd->suspend() [f68e3148]
BUG: unable to handle kernel paging request[...]
[...]

-- 
Tobias						PGP: http://9ac7e0bc.uguu.de
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/