linux-kernel - Re: [PATCH 01/06] Fix compilation warning for sound/soc/codecs/wm8400.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1247633018.2437.5.camel@ht.satnam>
Date:	Wed, 15 Jul 2009 10:13:38 +0530
From:	Jaswinder Singh Rajput <jaswinder@...nel.org>
To:	Subrata Modak <subrata@...ux.vnet.ibm.com>
Cc:	Jaroslav Kysela <erex@...ex.cz>, alsa-devel@...a-project.org,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Takashi Iwai <iwai@...e.de>,
	Sachin P Sant <sachinp@...ux.vnet.ibm.com>,
	David Howells <dhowells@...hat.com>,
	Balbir Singh <balbir@...ux.vnet.ibm.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 01/06] Fix compilation warning for
 sound/soc/codecs/wm8400.c

Hello Subrata,

On Wed, 2009-07-15 at 07:48 +0530, Subrata Modak wrote:
> Following fix is inspired by David Howells fix few days back:
> http://lkml.org/lkml/2009/7/9/109,
> 

Please check further of this thread :

http://marc.info/?l=linux-kernel&m=124756210124518&w=2


> Signed-off-by: Subrata Modak<subrata@...ux.vnet.ibm.com>,
> ---
> 
> --- a/sound/soc/codecs/wm8400.c	2009-06-15 07:52:31.000000000 +0530
> +++ b/sound/soc/codecs/wm8400.c	2009-07-15 05:35:00.000000000 +0530
> @@ -1015,7 +1015,7 @@ static int wm8400_set_dai_pll(struct snd
>  {
>  	struct snd_soc_codec *codec = codec_dai->codec;
>  	struct wm8400_priv *wm8400 = codec->private_data;
> -	struct fll_factors factors;
> +	struct fll_factors uninitialized_var(factors);
>  	int ret;
>  	u16 reg;
>  
> 

This kind of warnings born due to not handling the variables properly.
Please try to understand the root cause of this warning, just shutting
this warning is of no use.

Please revise your patches, If you face any problems let me know.

Thanks,
--
JSR

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/