linux-kernel - sound/soc/codecs/wm9081.c compiler warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1247639434.2437.14.camel@ht.satnam>
Date:	Wed, 15 Jul 2009 12:00:34 +0530
From:	Jaswinder Singh Rajput <jaswinder@...nel.org>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Takashi Iwai <tiwai@...e.de>,
	LKML <linux-kernel@...r.kernel.org>
Subject: sound/soc/codecs/wm9081.c compiler warning

I am getting this compiler warning in linus tree:

  CC [M]  sound/soc/codecs/wm9081.o
sound/soc/codecs/wm9081.c: In function ‘configure_clock’:
sound/soc/codecs/wm9081.c:674: warning: ‘new_sysclk’ may be used uninitialized in this function

This fixes the warning in my case, hope this will be helpful :

diff --git a/sound/soc/codecs/wm9081.c b/sound/soc/codecs/wm9081.c
index 86fc57e..77a7997 100644
--- a/sound/soc/codecs/wm9081.c
+++ b/sound/soc/codecs/wm9081.c
@@ -696,6 +696,7 @@ static int configure_clock(struct snd_soc_codec *codec)
 		 * not the case, though care must be taken with free
 		 * running mode.
 		 */
+		new_sysclk = 12288000;
 		if (wm9081->master && wm9081->bclk) {
 			/* Make sure we can generate CLK_SYS and BCLK
 			 * and that we've got 3MHz for optimal
@@ -714,8 +715,6 @@ static int configure_clock(struct snd_soc_codec *codec)
 				if (new_sysclk > 3000000)
 					break;
 			}
-		} else {
-			new_sysclk = 12288000;
 		}
 
 		ret = wm9081_set_fll(codec, WM9081_SYSCLK_FLL_MCLK,

--
JSR

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/