| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <87eish56zj.fsf@litku.valot.fi> Date: Thu, 16 Jul 2009 12:09:52 +0300 From: Kalle Valo <kalle.valo@....fi> To: Jiri Slaby <jirislaby@...il.com> Cc: linville@...driver.com, luciano.coelho@...ia.com, linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2] wireless: wl12xx, fix lock imbalance Jiri Slaby <jirislaby@...il.com> writes: > Add omitted mutex_unlock to one of wl12xx_op_start fail paths (when > wl12xx_chip_wakeup fails). Thanks for fixing this. > [v2] > Power off the device, because: > \= cite from http://marc.info/?l=linux-kernel&m=124755028209880&w=2 > If the chip cannot be booted, why should it remain powered on? > In some rare cases, the chip might fail to initialize, but can > recover if powered off and on again, so turning it off at this > point is the right thing to do. =/ Yes, I agree with this. > Signed-off-by: Jiri Slaby <jirislaby@...il.com> > --- > drivers/net/wireless/wl12xx/main.c | 2 +- Unfortunately this won't apply to wireless-testing because main.c is renamed to wl1251_main.c. Can you respin the patch or do you want me to do it? I'm sending other wl12xx patches anyway and it's easy for me to rebase this one at the same time. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists