linux-kernel - Re: [PATCH 02/06] Fix compilation warning for fs/ubifs/commit.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1247742765.11353.114.camel@localhost.localdomain>
Date:	Thu, 16 Jul 2009 14:12:45 +0300
From:	Artem Bityutskiy <dedekind@...radead.org>
To:	subrata@...ux.vnet.ibm.com
Cc:	Stefan Richter <stefanr@...6.in-berlin.de>,
	linux-mtd@...ts.infradead.org,
	Adrian Hunter <adrian.hunter@...ia.com>,
	Sachin P Sant <sachinp@...ux.vnet.ibm.com>,
	David Howells <dhowells@...hat.com>,
	Balbir Singh <balbir@...ux.vnet.ibm.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 02/06] Fix compilation warning for fs/ubifs/commit.c

On Thu, 2009-07-16 at 16:34 +0530, Subrata Modak wrote:
> Correct. There has been other warning fixes i have sent to LKML, where i
> have tweaked the code to fix the compilation, but, code tweaking may not
> be possible in this case. However , i would  still investigate.

I do not think that in _general_ it is a good idea to tweak code just
to have gcc pleased, granted the code is correct. In this case it is
more preferable to shut it up, e.g., using 'unitialized_var()'.

-- 
Best regards,
Artem Bityutskiy (Битюцкий Артём)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/