linux-kernel - Re: [PATCH -tip -v12 01/11] x86: instruction decoder API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 Jul 2009 13:28:54 -0400
From:	Masami Hiramatsu <mhiramat@...hat.com>
To:	Ingo Molnar <mingo@...e.hu>, Steven Rostedt <rostedt@...dmis.org>,
	lkml <linux-kernel@...r.kernel.org>,
	systemtap <systemtap@...rces.redhat.com>,
	kvm <kvm@...r.kernel.org>,
	DLE <dle-develop@...ts.sourceforge.net>,
	Jim Keniston <jkenisto@...ibm.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Andi Kleen <ak@...ux.intel.com>,
	Vegard Nossum <vegard.nossum@...il.com>,
	Avi Kivity <avi@...hat.com>,
	Przemys??awPawe??czyk <przemyslaw@...elczyk.it>
Subject: Re: [PATCH -tip -v12 01/11] x86: instruction decoder API

Sam Ravnborg wrote:
>> diff --git a/arch/x86/include/asm/inat.h b/arch/x86/include/asm/inat.h
>> new file mode 100644
>> index 0000000..01e079a
>> --- /dev/null
>> +++ b/arch/x86/include/asm/inat.h
>> @@ -0,0 +1,125 @@
>> +#ifndef _ASM_INAT_INAT_H
>> +#define _ASM_INAT_INAT_H
> 
> [With reference to comment on patch 2/12...]
> You create inat.h here.
> Could you investigave what is needed to factor out the stuff
> needed from userspace so we can avoid the ugly havk where
> you redefine types.h?

Sorry, I'm a bit confusing.
Would you mean that I should break down user_include.h and
add those redefined types in inat.h?

> Maybe create a inat_types.h + inat.h as we do in other cases?

And inat_types.h has two parts, one for kernel, and one for
userspace(which is moved from user_include.h), is that right?

Thank you,

> 
> Same for the other files that requred the types.h hack.
> 
> 	Sam
> 

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division

e-mail: mhiramat@...hat.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/