linux-kernel - Re: + mm-vmstat-add-isolate-pages.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20090716143311.9D3A.A69D9226@jp.fujitsu.com>
Date:	Thu, 16 Jul 2009 14:34:54 +0900 (JST)
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Cc:	kosaki.motohiro@...fujitsu.com, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, fengguang.wu@...el.com,
	minchan.kim@...il.com, riel@...hat.com
Subject: Re: + mm-vmstat-add-isolate-pages.patch added to -mm tree

> On Wed, 15 Jul 2009 20:21:36 -0700
> akpm@...ux-foundation.org wrote:
> > ------------------------------------------------------
> > Subject: mm: vmstat: add isolate pages
> > From: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
> > 
> 
> Hi, Kosaki,
> 
> > If the system is running a heavy load of processes then concurrent reclaim
> > can isolate a large number of pages from the LRU. /proc/meminfo and the
> > output generated for an OOM do not show how many pages were isolated.
> > 
> <snip>
>  
> > @@ -742,6 +746,13 @@ int migrate_pages(struct list_head *from
> >  	struct page *page2;
> >  	int swapwrite = current->flags & PF_SWAPWRITE;
> >  	int rc;
> > +	int flags;
> 
> unsigned long.

Grr. yes my fault.


> > +
> > +	local_irq_save(flags);
> > +	list_for_each_entry(page, from, lru)
> > +		__inc_zone_page_state(page, NR_ISOLATED_ANON +
> > +				      !!page_is_file_cache(page));
> > +	local_irq_restore(flags);

Fixing patch is here ;-)


Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
---
 mm/migrate.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: b/mm/migrate.c
===================================================================
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -744,7 +744,7 @@ int migrate_pages(struct list_head *from
 	struct page *page2;
 	int swapwrite = current->flags & PF_SWAPWRITE;
 	int rc;
-	int flags;
+	unsigned long flags;
 
 	local_irq_save(flags);
 	list_for_each_entry(page, from, lru)




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/