linux-kernel - Re: [PATCH V2] block: sysfs fix mismatched queue_var

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A601ED2.50800@kernel.org>
Date:	Fri, 17 Jul 2009 15:48:50 +0900
From:	Tejun Heo <tj@...nel.org>
To:	Xiaotian Feng <dfeng@...hat.com>
CC:	axboe@...nel.dk, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] block: sysfs fix mismatched queue_var_{store,show}
 in 64bit kernel

Hello, Xiaotian.

Xiaotian Feng wrote:
>  static ssize_t queue_ra_show(struct request_queue *q, char *page)
>  {
> -	int ra_kb = q->backing_dev_info.ra_pages << (PAGE_CACHE_SHIFT - 10);
> +	unsigned long ra_kb = q->backing_dev_info.ra_pages <<
> +					(PAGE_CACHE_SHIFT - 10);
>  
>  	return queue_var_show(ra_kb, (page));
>  }

Nice.

> @@ -95,7 +96,7 @@ queue_ra_store(struct request_queue *q, const char *page, size_t count)
>  
>  static ssize_t queue_max_sectors_show(struct request_queue *q, char *page)
>  {
> -	int max_sectors_kb = queue_max_sectors(q) >> 1;
> +	unsigned long max_sectors_kb = queue_max_sectors(q) >> 1;
>  
>  	return queue_var_show(max_sectors_kb, (page));
>  }
> @@ -140,7 +141,7 @@ queue_max_sectors_store(struct request_queue *q, const char *page, size_t count)
>  
>  static ssize_t queue_max_hw_sectors_show(struct request_queue *q, char *page)
>  {
> -	int max_hw_sectors_kb = queue_max_hw_sectors(q) >> 1;
> +	unsigned long max_hw_sectors_kb = queue_max_hw_sectors(q) >> 1;
>  
>  	return queue_var_show(max_hw_sectors_kb, (page));
>  }

The above two aren't necessary but well why not.

> @@ -189,7 +190,7 @@ static ssize_t queue_nomerges_store(struct request_queue *q, const char *page,
>  
>  static ssize_t queue_rq_affinity_show(struct request_queue *q, char *page)
>  {
> -	unsigned int set = test_bit(QUEUE_FLAG_SAME_COMP, &q->queue_flags);
> +	unsigned long set = test_bit(QUEUE_FLAG_SAME_COMP, &q->queue_flags);
>  
>  	return queue_var_show(set != 0, page);
>  }

Wouldn't it be better to make it "bool set = " and then remove the
"!= 0"?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/