[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1247842508.2335.4.camel@localhost>
Date: Fri, 17 Jul 2009 16:55:08 +0200
From: Jerome Glisse <glisse@...edesktop.org>
To: Michel Dänzer <michel@...nzer.net>
Cc: Dave Airlie <airlied@...hat.com>, linux-kernel@...r.kernel.org,
dri-devel@...ts.sf.net
Subject: Re: [PATCH] ttm: add pool wc/uc page allocator
On Fri, 2009-07-17 at 10:01 +0200, Michel Dänzer wrote:
> On Thu, 2009-07-16 at 18:34 +0200, Jerome Glisse wrote:
> > On Thu, 2009-07-16 at 18:13 +0200, Jerome Glisse wrote:
> > > On AGP system we might allocate/free routinely uncached or wc memory,
> > > changing page from cached (wb) to uc or wc is very expensive and involves
> > > a lot of flushing. To improve performance this allocator use a pool
> > > of uc,wc pages.
> > >
> > > Currently each pool (wc, uc) is 256 pages big, improvement would be
> > > to tweak this according to memory pressure so we can give back memory
> > > to system.
> > >
> > > Signed-off-by: Dave Airlie <airlied@...hat.com>
> > > Signed-off-by: Jerome Glisse <jglisse@...hat.com>
> >
> > Just a follow-up on that one, i haven't been able yet to thoroughly
> > test this patch on AGP system, so i am mostly sending so other people
> > can test. I think i corrected few bugs that were in previous iteration
> > of that patch.
> >
> > Beside that i think i have addressed all comment previously raisen,
> > but don't hesitate to pin point any things i have miss.
>
> This one works a little better on my PowerBook than the previous one:
>
> PCI GART works (failed to allocate the ring buffer before)
> AGP fails to allocate the ring buffer (paniced at KMS init before)
>
Attached a new version which more or less work on x86 agp (i have
screen corruption haven't tracked done what is causing it yet).
I corrected more bugs from previous version, hopefully i am getting
closer to somethings which works.
Cheers,
Jerome
View attachment "0001-ttm-add-pool-wc-uc-page-allocator.patch" of type "text/x-patch" (15271 bytes)
Powered by blists - more mailing lists